Skip to content

Conversation

Serchinastico
Copy link
Contributor

Summary

This PR updates ESLint to version 9 for all created projects and for this very same repository as well.

Upgrading to ESLint 9 implies moving the inline ESLint config (located at package.json) to a separate file: .eslint.config.mjs (docs).

We are coming from discussion #793

Test plan

  • Run yarn lint in this project to make sure linting is unaffected.
  • Create a new project with create-react-native-library and run yarn lint on the newly created project to make sure linting does not report any error.

@Serchinastico Serchinastico changed the title Update eslint Update eslint to v9 Mar 18, 2025
@Serchinastico Serchinastico changed the title Update eslint to v9 feat: update eslint to v9 Mar 18, 2025
@satya164
Copy link
Member

Hey @Serchinastico, I have now migrated eslint-config-satya164 to ESLint 9 so you should be able to drop the compact related code.

These changes include:
- Adding the new required dependencies for eslint v9
  (e.g. @eslint/eslintrc, @eslint/js, etc).
- Include eslint's compat package to continue using
  @react-native/eslint-config with the new config format.
- Move the inline eslint config (located in package.json) to the new
  flat file config format, in a separate file.
@Serchinastico
Copy link
Contributor Author

Hey @Serchinastico, I have now migrated eslint-config-satya164 to ESLint 9 so you should be able to drop the compact related code.

Awesome, I updated the PR with version [email protected]. Just an update, some of the rules have changed in the update and had to add/change some ignore directives.

@satya164 satya164 requested a review from atlj March 27, 2025 13:09
@satya164 satya164 force-pushed the main branch 2 times, most recently from 9ca6093 to 72a579c Compare March 27, 2025 16:42
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@satya164 satya164 added this pull request to the merge queue Mar 28, 2025
Merged via the queue into callstack:main with commit d056559 Mar 28, 2025
21 checks passed
@Serchinastico Serchinastico deleted the update-eslint branch March 28, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants