fix: prevent example app from adding newArchEnabled if already present #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
👋 Hey! I was creating a new library and noticed that the generated
example/android/gradle.propertiesfile had thenewArchEnabled=truesetting duplicated. I think it has to do with the vanilla example app now setting the flag to true by default (@react-native-community/cli), but I can't point to a specific commit or dependency that causes it 🤷♂️.In any case, the change should be safe even if they revert it so there's that.
Test plan
example/android/gradle.propertiesfile has no duplicatednewArchEnabled=truelines.