Skip to content

remove react-native-safe-area-context from example app #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove react-native-safe-area-context from example app #897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/create-react-native-library/src/exampleApp/generateExampleApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const PACKAGES_TO_REMOVE = [
'prettier',
'react-test-renderer',
'typescript',
'react-native-safe-area-context',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Safe Area Context Removal Issue

Adding react-native-safe-area-context to PACKAGES_TO_REMOVE might not fully remove it from the example app. PACKAGES_TO_REMOVE only targets devDependencies, but react-native-safe-area-context is typically a regular dependency. This means the package could persist, potentially preventing the intended fix for a build crash.

Fix in Cursor Fix in Web

];

const PACKAGES_TO_ADD_WEB = {
Expand Down
Loading