Skip to content

fix: measureInWindow on web platform #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
Merged

fix: measureInWindow on web platform #4

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f079360
fix: measureInWindow on web platform
renanmav Aug 18, 2025
36455a6
fix: simplify measureInWindow logic for Shimmer component
renanmav Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Shimmer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
type ViewStyle,
Dimensions,
type LayoutChangeEvent,
Platform,
} from 'react-native';
import Animated, {
Easing,
Expand Down Expand Up @@ -51,7 +52,11 @@
const measure = useCallback(
(event: LayoutChangeEvent) => {
if (componentWidth === 0) {
event.target.measureInWindow((x, _y, width) => {
const measureInWindowFn =
Platform.OS === 'web'
? event.nativeEvent.target.measureInWindow

Check failure on line 57 in src/Shimmer.tsx

View workflow job for this annotation

GitHub Actions / lint 

Property 'target' does not exist on type '{ layout: LayoutRectangle; }'.
: event.target.measureInWindow;
measureInWindowFn((x, _y, width) => {

Check failure on line 59 in src/Shimmer.tsx

View workflow job for this annotation

GitHub Actions / lint 

Parameter 'width' implicitly has an 'any' type.

Check failure on line 59 in src/Shimmer.tsx

View workflow job for this annotation

GitHub Actions / lint 

Parameter '_y' implicitly has an 'any' type.

Check failure on line 59 in src/Shimmer.tsx

View workflow job for this annotation

GitHub Actions / lint 

Parameter 'x' implicitly has an 'any' type.
setComponentWidth(width);
setOffset(x);
});
Expand Down
Loading