removing incorrect onPress params type #3307
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @JDMathew , could you please rename the commit to follow the commit naming convention? |
lukewalczak
force-pushed
the
main
branch
6 times, most recently
from
1062366 to
1da5d15
Compare
Author
|
@lukewalczak, I have updated the commit. (Only saw this now thanks to Arc browser) |
lukewalczak
reviewed
May 9, 2025
| * Function to execute on press. | ||
| */ | ||
| onPress?: (param?: any) => void; | ||
| onPress?: () => void; |
Member
There was a problem hiding this comment.
Right now as I'm checking it, I think it should be:
onPress?: (e: GestureResponderEvent) => void;
Suggested change
| onPress?: () => void; | |
| onPress?: (e: GestureResponderEvent) => void; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The type for onPress was incorrect for Android (default) Radio button
Test plan
Fixed warning in TS