Skip to content

fix: TextInput loses focus inside Banner on iOS only #4179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: TextInput loses focus inside Banner on iOS only #4179

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74e81a9
fix: TextInput loses focus inside Banner on iOS only #4178
abdulbasithqb Nov 13, 2023
1053af1
Merge pull request #2 from abdulbasithqb/fixes/banner-focus-fix
abdulbasithqb Nov 13, 2023
f1f8c58
fix: removed duplicated style content
abdulbasithqb Nov 28, 2023
b05b54e
Merge pull request #6 from abdulbasithqb/fixes/banner-focus-fix
abdulbasithqb Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 31 additions & 15 deletions src/components/Banner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,36 @@ const Banner = ({
Animated.add(position, -1),
layout.height
);

const renderChildrenWithWrapper = () => {
if (typeof children === 'string') {
return (
<Text
style={[
styles.message,
{
color: theme.isV3 ? theme.colors.onSurface : theme.colors.text,
},
]}
accessibilityLiveRegion={visible ? 'polite' : 'none'}
accessibilityRole="alert"
maxFontSizeMultiplier={maxFontSizeMultiplier}
>
{children}
</Text>
);
}
return (
<View
style={styles.content}
accessibilityLiveRegion={visible ? 'polite' : 'none'}
accessibilityRole="alert"
>
{children}
</View>
);
};

return (
<Surface
{...rest}
Expand Down Expand Up @@ -220,21 +250,7 @@ const Banner = ({
<Icon source={icon} size={40} />
</View>
) : null}
<Text
style={[
styles.message,
{
color: theme.isV3
? theme.colors.onSurface
: theme.colors.text,
},
]}
accessibilityLiveRegion={visible ? 'polite' : 'none'}
accessibilityRole="alert"
maxFontSizeMultiplier={maxFontSizeMultiplier}
>
{children}
</Text>
{renderChildrenWithWrapper()}
</View>
<View style={styles.actions}>
{actions.map(({ label, ...others }, i) => (
Expand Down