Skip to content

fix: input label not visible on ios if multiline, fixes #4482 #4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged

fix: input label not visible on ios if multiline, fixes #4482 #4497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68ad214
fix: input label not visible on ios if multiline, fixes #4482
damianfilipek81 Sep 14, 2024
c7b74e0
fix: remove unnecessary styling from InputLabel
BogiKay Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/TextInput/Label/InputLabel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,12 @@ const InputLabel = (props: InputLabelProps) => {
// This gives the effect of animating the color, but allows us to use native driver
<View
pointerEvents="none"
style={[StyleSheet.absoluteFill, styles.overflow]}
style={[StyleSheet.absoluteFill, styles.overflow, styles.labelContainer]}
>
<Animated.View
pointerEvents="none"
style={[
StyleSheet.absoluteFill,
styles.labelContainer,
Platform.OS !== 'web' && { width },
{ opacity },
labelTranslationX,
Expand Down
36 changes: 27 additions & 9 deletions src/components/__tests__/__snapshots__/TextInput.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ exports[`call onPress when affix adornment pressed 1`] = `
{
"overflow": "hidden",
},
{
"zIndex": 3,
},
]
}
>
Expand All @@ -82,7 +85,6 @@ exports[`call onPress when affix adornment pressed 1`] = `
},
],
"width": 750,
"zIndex": 3,
}
}
>
Expand Down Expand Up @@ -358,6 +360,9 @@ exports[`correctly applies a component as the text label 1`] = `
{
"overflow": "hidden",
},
{
"zIndex": 3,
},
]
}
>
Expand All @@ -378,7 +383,6 @@ exports[`correctly applies a component as the text label 1`] = `
},
],
"width": 750,
"zIndex": 3,
}
}
>
Expand Down Expand Up @@ -598,6 +602,9 @@ exports[`correctly applies cursorColor prop 1`] = `
{
"overflow": "hidden",
},
{
"zIndex": 3,
},
]
}
>
Expand All @@ -618,7 +625,6 @@ exports[`correctly applies cursorColor prop 1`] = `
},
],
"width": 750,
"zIndex": 3,
}
}
>
Expand Down Expand Up @@ -822,6 +828,9 @@ exports[`correctly applies default textAlign based on default RTL 1`] = `
{
"overflow": "hidden",
},
{
"zIndex": 3,
},
]
}
>
Expand All @@ -842,7 +851,6 @@ exports[`correctly applies default textAlign based on default RTL 1`] = `
},
],
"width": 750,
"zIndex": 3,
}
}
>
Expand Down Expand Up @@ -1039,6 +1047,9 @@ exports[`correctly applies height to multiline Outline TextInput 1`] = `
{
"overflow": "hidden",
},
{
"zIndex": 3,
},
]
}
>
Expand All @@ -1059,7 +1070,6 @@ exports[`correctly applies height to multiline Outline TextInput 1`] = `
},
],
"width": 750,
"zIndex": 3,
}
}
>
Expand Down Expand Up @@ -1303,6 +1313,9 @@ exports[`correctly applies paddingLeft from contentStyleProp 1`] = `
{
"overflow": "hidden",
},
{
"zIndex": 3,
},
]
}
>
Expand All @@ -1323,7 +1336,6 @@ exports[`correctly applies paddingLeft from contentStyleProp 1`] = `
},
],
"width": 750,
"zIndex": 3,
}
}
>
Expand Down Expand Up @@ -1529,6 +1541,9 @@ exports[`correctly applies textAlign center 1`] = `
{
"overflow": "hidden",
},
{
"zIndex": 3,
},
]
}
>
Expand All @@ -1549,7 +1564,6 @@ exports[`correctly applies textAlign center 1`] = `
},
],
"width": 750,
"zIndex": 3,
}
}
>
Expand Down Expand Up @@ -1753,6 +1767,9 @@ exports[`correctly renders left-side affix adornment, and right-side icon adornm
{
"overflow": "hidden",
},
{
"zIndex": 3,
},
]
}
>
Expand All @@ -1773,7 +1790,6 @@ exports[`correctly renders left-side affix adornment, and right-side icon adornm
},
],
"width": 750,
"zIndex": 3,
}
}
>
Expand Down Expand Up @@ -2179,6 +2195,9 @@ exports[`correctly renders left-side icon adornment, and right-side affix adornm
{
"overflow": "hidden",
},
{
"zIndex": 3,
},
]
}
>
Expand All @@ -2199,7 +2218,6 @@ exports[`correctly renders left-side icon adornment, and right-side affix adornm
},
],
"width": 750,
"zIndex": 3,
}
}
>
Expand Down