fix: invalid touchable area on mobile browser #4514
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @abretonc7s, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
personalizedrefrigerator
added a commit
to personalizedrefrigerator/joplin
that referenced
this pull request
Nov 6, 2024
…n certain Android devices This commit adjusts an accessibility bug workaround from (laurent22#10123), which was first present in Android v3.0.1. **Background**: React Native Paper's FAB.Group by default renders an invisible <View> that covers most/all of Joplin's UI when the FAB.Group is collapsed. This breaks TalkBack on Android's "tap to navigate" feature, which significantly impacts users that rely on TalkBack's ability to use the app. Starting from Joplin v3.0.1, the <View> added by React Native is made smaller by Joplin by adding margins above and to the left. These margins are determined by the screen size and an offset. This solution isn't perfect because it means that a small portion of the screen still blocks TalkBack's tap-to-navigate. As reported in laurent22#11276, this workaround also pushed the new note/new to-do buttons offscren. **The change** This commit changes how the FAB.Group's invisible <View> is resized. Previously it was done with margins. Now, it's done with the top/left absolute positioning properties. **Note** If [this upstream pull request](callstack/react-native-paper#4514) is merged, it should be possible to remove the workaround entirely. **Remaining steps** More testing is required before a pull request can be opened. For now, (in part because this is not a regression from v3.0), I plan to target release-3.2, rather than release-3.1, to avoid introducing additional regressions in the 3.1 version of the app. Should fix laurent22#11276, laurent22#11315.
This was referenced Nov 6, 2024
personalizedrefrigerator
added a commit
to personalizedrefrigerator/joplin
that referenced
this pull request
Nov 7, 2024
…n certain Android devices This commit adjusts an accessibility bug workaround from (laurent22#10123), which was first present in Android v3.0.1. **Background**: React Native Paper's FAB.Group by default renders an invisible <View> that covers most/all of Joplin's UI when the FAB.Group is collapsed. This breaks TalkBack on Android's "tap to navigate" feature, which significantly impacts users that rely on TalkBack's ability to use the app. Starting from Joplin v3.0.1, the <View> added by React Native is made smaller by Joplin by adding margins above and to the left. These margins are determined by the screen size and an offset. This solution isn't perfect because it means that a small portion of the screen still blocks TalkBack's tap-to-navigate. As reported in laurent22#11276, this workaround also pushed the new note/new to-do buttons offscren. **The change** This commit changes how the FAB.Group's invisible <View> is resized. Previously it was done with margins. Now, it's done with the top/left absolute positioning properties. **Note** If [this upstream pull request](callstack/react-native-paper#4514) is merged, it should be possible to remove the workaround entirely. **Remaining steps** More testing is required before a pull request can be opened. For now, (in part because this is not a regression from v3.0), I plan to target release-3.2, rather than release-3.1, to avoid introducing additional regressions in the 3.1 version of the app. Should fix laurent22#11276, laurent22#11315.
Member
|
Closing in favour of: #4692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issue described below for mobile browser web
Related issue
Test plan