Skip to content

Conversation

@maciekBudzinski
Copy link

This PR fixes the issue with MaterialBottomTabsNavigator when used with react-native-screens by setting removeClippedSubviews for BottomNavigation scene to false.

Motivation

Having this flag set to true was causing android application to crash when the MaterialBottomTabsNavigator was used inside native stack navigator.

Related issue

Closes #4546

Test plan

Tested on https://github.com/maciekBudzinski/rnp-material-bottom-tabs-repro-issue

Before:

before.webm

After:

after.webm

@callstack-bot
Copy link

Hey @maciekBudzinski, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@angelov-selyami
Copy link

This fix is essential for resolving my issue with BottomTabNavigation. Please merge it soon. :)

@salememd
Copy link

We urgently need this fix. Thank,

@ysoni24
Copy link

ysoni24 commented Dec 18, 2024

this doesn't wok on android. had to set removeClippedSubviews to false to make it work. please have a look into the issue.

@lukewalczak
Copy link
Member

According to the latest updates from react-native-screens I'm closing the issue. More: software-mansion/react-native-screens#2491 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot remove child at index X from parent ViewGroup X, only Xchildren in parent. Warning: childCount may be incorrect!

6 participants