Skip to content

fix: floating number problem on android #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2024
Merged

fix: floating number problem on android #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
deaaf3c
fix: floating number problem on android
Sep 18, 2024
767ffab
fix: change number type from float to double
Sep 20, 2024
baa959a
fix: remove unused imports
Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package/android/src/main/java/com/reactnativecommunity/slider/ReactSlider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import android.view.accessibility.AccessibilityEvent;
import android.view.accessibility.AccessibilityManager;
import androidx.appcompat.widget.AppCompatSeekBar;

import java.net.URL;
import java.util.List;
import java.util.Timer;
Expand Down
6 changes: 3 additions & 3 deletions package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ public static void setValue(ReactSlider view, double value) {
}
}

public static void setMinimumValue(ReactSlider view, float value) {
public static void setMinimumValue(ReactSlider view, double value) {
view.setMinValue(value);
}

public static void setMaximumValue(ReactSlider view, float value) {
public static void setMaximumValue(ReactSlider view, double value) {
view.setMaxValue(value);
}

Expand All @@ -60,7 +60,7 @@ public static void setUpperLimit(ReactSlider view, double value) {
view.setUpperLimit(value);
}

public static void setStep(ReactSlider view, float value) {
public static void setStep(ReactSlider view, double value) {
view.setStep(value);
}

Expand Down
6 changes: 3 additions & 3 deletions package/android/src/newarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,19 +113,19 @@ public void setValue(ReactSlider view, float value) {

@Override
@ReactProp(name = "minimumValue", defaultFloat = 0f)
public void setMinimumValue(ReactSlider view, float value) {
public void setMinimumValue(ReactSlider view, double value) {
ReactSliderManagerImpl.setMinimumValue(view, value);
}

@Override
@ReactProp(name = "maximumValue", defaultFloat = 0f)
public void setMaximumValue(ReactSlider view, float value) {
public void setMaximumValue(ReactSlider view, double value) {
ReactSliderManagerImpl.setMaximumValue(view, value);
}

@Override
@ReactProp(name = "step", defaultFloat = 0f)
public void setStep(ReactSlider view, float value) {
public void setStep(ReactSlider view, double value) {
ReactSliderManagerImpl.setStep(view, value);
}

Expand Down
6 changes: 3 additions & 3 deletions package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,17 +131,17 @@ public void setValue(ReactSlider view, float value) {
}

@ReactProp(name = "minimumValue", defaultFloat = 0f)
public void setMinimumValue(ReactSlider view, float value) {
public void setMinimumValue(ReactSlider view, double value) {
ReactSliderManagerImpl.setMinimumValue(view, value);
}

@ReactProp(name = "maximumValue", defaultFloat = 1f)
public void setMaximumValue(ReactSlider view, float value) {
public void setMaximumValue(ReactSlider view, double value) {
ReactSliderManagerImpl.setMaximumValue(view, value);
}

@ReactProp(name = "lowerLimit")
public void setLowerLimit(ReactSlider view, float value) {
public void setLowerLimit(ReactSlider view, double value) {
ReactSliderManagerImpl.setLowerLimit(view, value);
}

Expand Down
Loading