Skip to content

Conversation

BartoszKlonowski
Copy link
Member

@BartoszKlonowski BartoszKlonowski commented Jun 5, 2025

This pull request fixes #711

It migrates from ImageSource type from RN to ImageURISource. Those are both from RN and have common props however ImageSource is no longer supported by the v0.79 app (and beyond).

This fix includes both iOS and Android.
Also, all dev deps were updated to make sure we have the recent types used within the package when consumed by the app.

Note:: Removing tests from workflow is temporary due to versions update and tests now failing (some features of React test were used previously).

Comment on lines +226 to +230
img->size.width = newScreenProps.thumbImage.width;
img->size.height = newScreenProps.thumbImage.height;
img->scale = newScreenProps.thumbImage.scale;
img->bundle = newScreenProps.thumbImage.bundle;
img->uri = newScreenProps.thumbImage.uri;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess now codegen treats our ImageSource as a custom type so it generates an intermediate representation of it. I wonder if there is a built-in way to handle it 🤔

But it looks good as a fix for now

@Qdafengzi
Copy link

Looking forward to merging into main line release soon, thanks

@brianlenz
Copy link

@BartoszKlonowski I wanted to check to see if you have any updates as to when this might be merged and released? We're unable to use a custom thumbImage in newer versions of React Native (e.g. 0.80.2).

@brianlenz
Copy link

@BartoszKlonowski FWIW, I forked the repo and merged the changes here into 5.0.1. It fixes the issue with the iOS thumb image not working 🙏

@BartoszKlonowski
Copy link
Member Author

@brianlenz @Qdafengzi Thank you for the interest and checking the solution!
It's been a while since I had a possibility to sit down to it, but in the meantime, together with @okwasniewski (thanks!) we figured out that what is implemented in this PR is rather a workaround and we should rather stick to ImageSource.
Considering input provided in #734 by @pingkai there is an option to figure out a better solution soon.
I'm hoping for your patience while we'll be pushing the topic forward, and in the meantime please reach out to a workaround suggested in #734.
I will keep this thread active as soon as there will be more findings or ETAs.
Thank you!

@lapidcj
Copy link

lapidcj commented Sep 21, 2025

mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to add a thumbImage without having a StepMarker
5 participants