-
Notifications
You must be signed in to change notification settings - Fork 293
Use ImageURISource
for thumb image instead of ImageSource
to fix image not loading
#714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
img->size.width = newScreenProps.thumbImage.width; | ||
img->size.height = newScreenProps.thumbImage.height; | ||
img->scale = newScreenProps.thumbImage.scale; | ||
img->bundle = newScreenProps.thumbImage.bundle; | ||
img->uri = newScreenProps.thumbImage.uri; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess now codegen treats our ImageSource as a custom type so it generates an intermediate representation of it. I wonder if there is a built-in way to handle it 🤔
But it looks good as a fix for now
Looking forward to merging into main line release soon, thanks |
@BartoszKlonowski I wanted to check to see if you have any updates as to when this might be merged and released? We're unable to use a custom |
@BartoszKlonowski FWIW, I forked the repo and merged the changes here into 5.0.1. It fixes the issue with the iOS thumb image not working 🙏 |
@brianlenz @Qdafengzi Thank you for the interest and checking the solution! |
mark |
This pull request fixes #711
It migrates from
ImageSource
type from RN toImageURISource
. Those are both from RN and have common props howeverImageSource
is no longer supported by the v0.79 app (and beyond).This fix includes both iOS and Android.
Also, all dev deps were updated to make sure we have the recent types used within the package when consumed by the app.
Note:: Removing tests from workflow is temporary due to versions update and tests now failing (some features of React test were used previously).