fix: Add file protocol support for script loading in ScriptManager #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1f3618b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
@longb1997 I'll try to review this week, thank you for your patience |
Member
|
Thank you for your contribution @longb1997, these are very meaningful fixes! 🎉 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds support for the file protocol in the ScriptManager module for both Android (ScriptManagerModule.kt) and iOS (ScriptManager.mm). The change enables loading scripts directly from the local filesystem, addressing scenarios where scripts are stored locally rather than fetched remotely via HTTP/HTTPS.
This enhances the flexibility of the script loading mechanism in Re.pack.The changes include:
On Android: Added a condition in ScriptManagerModule.kt to handle file protocol URLs by delegating to fileSystemLoader.load.
On iOS: Added a condition in ScriptManager.mm to handle file protocol URLs by calling executeFromFilesystem.
resolve #1148
Test plan
build a bundle mini app then load it locally