Skip to content

fix: use singleton terminal instance per process #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbroma merged 2 commits into from
Aug 19, 2025
Merged

fix: use singleton terminal instance per process #1261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06de98c
fix: use singleton terminal instance
jbroma Aug 19, 2025
a38f340
chore: changeset
jbroma Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-cats-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@callstack/repack": patch
---

Use single terminal instance per process to ensure proper log message scheduling
15 changes: 8 additions & 7 deletions packages/repack/src/logging/reporters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,16 +82,17 @@ const FALLBACK_SYMBOLS: Record<LogType, string> = {

const PROGRESS_BAR_WIDTH = 16;

// singleton instance within the same process
// TODO clean this up in 6.0
const terminal = new MultiPlatformTerminal(process.stdout);

class InteractiveConsoleReporter implements Reporter {
private requestBuffer: Record<string, Object> = {};
private terminal: MultiPlatformTerminal;
private startTimeByPlatform: Record<string, number> = {};
private spinner: Spinner = new Spinner();
private maxPlatformNameWidth = 0;

constructor(private config: ConsoleReporterConfig) {
this.terminal = new MultiPlatformTerminal(process.stdout);
}
constructor(private config: ConsoleReporterConfig) {}

process(log: LogEntry) {
// Do not log debug messages in non-verbose mode
Expand All @@ -106,7 +107,7 @@ class InteractiveConsoleReporter implements Reporter {

const normalizedLog = this.normalizeLog(log);
if (normalizedLog) {
this.terminal.log(
terminal.log(
`${
IS_SYMBOL_SUPPORTED ? SYMBOLS[log.type] : FALLBACK_SYMBOLS[log.type]
} ${this.prettifyLog(normalizedLog)}`
Expand Down Expand Up @@ -208,14 +209,14 @@ class InteractiveConsoleReporter implements Reporter {
}

if (typeof time === 'number') {
this.terminal.status(
terminal.status(
platform,
this.buildDoneLine(platform, time, log.timestamp, log.issuer)
);
return;
}

this.terminal.status(
terminal.status(
platform,
this.buildInProgressLine(platform, percentage, log.timestamp, log.issuer)
);
Expand Down