Skip to content

Conversation

@ddolny
Copy link
Collaborator

@ddolny ddolny commented Nov 18, 2025

This PR introduces the following:

  • Ottrelite Gradle Plugin moved to separate directory
  • Plugin published to the https://plugins.gradle.org/
  • Modified example to use published plugin instead of the one from buildSrc

Note

Moves the Ottrelite Android Gradle plugin into a standalone, publishable module and updates the example to consume it; adds new Android APIs and renames traceCounter to counterEvent.

  • Gradle Plugin (standalone):
    • New module plugin/ottrelite-gradle-plugin with Gradle wrapper, settings.gradle.kts, and publishing config for com.callstack.ottrelite (v0.1.0).
    • Refactor instrumentation: move ReplacementDescriptor to com.callstack.plugin.model and split ReplacementDescriptorList; update mapping (traceCounter -> counterEvent); simplify logging.
    • Extract OttreliteTracingExtension into its own file; minor cleanup in variant selection logic.
  • Example App:
    • Remove android/buildSrc plugin; add classpath dependency com.callstack:ottrelite-plugin:0.1.0 in examples/rn-app/android/build.gradle.
  • Core Android API (packages/core/android/.../OttreliteAndroid.kt):
    • Add beginAsyncEvent(eventName, argsMap) and beginEvent(sectionName, argsMap) overloads.
    • Rename traceCounter to counterEvent and add Double overload.

Written by Cursor Bugbot for commit 1ce7e1f. This will update automatically on new commits. Configure here.

@ddolny ddolny requested a review from artus9033 November 18, 2025 17:39
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Replaced the classpath with shorter nicer looking one
@@ -0,0 +1,36 @@
import org.jetbrains.kotlin.gradle.internal.backend.common.serialization.metadata.DynamicTypeDeserializer.id
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Internal Kotlin Import Violates Best Practices

Unused import from internal Kotlin package. The import org.jetbrains.kotlin.gradle.internal.backend.common.serialization.metadata.DynamicTypeDeserializer.id is never used in the file and imports from internal APIs (indicated by .internal. in the path), which violates best practices and may cause compilation failures depending on the Kotlin/Gradle version and build configuration.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants