-
Notifications
You must be signed in to change notification settings - Fork 8
fix(runtime): bump chai to v6 #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime): bump chai to v6 #37
Conversation
|
@bheemreddy-samsara is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
Update vitest expect/spy to 4.0.16 so runtime uses chai ^6.2.x. This avoids BigInt literal (0n) parsing failures in Hermes.
341ec7b to
955a87e
Compare
|
@V3RON Can i get a review ? |
|
ref chaijs/chai#1748 |
|
Hi @bheemreddy-samsara! |
|
Thanks! @V3RON This doesn’t show up in the repo’s JS/unit tests — it happens when the harness runtime is executed inside the app (Hermes) on device/simulator. In our RN App we saw the app crash on startup with a Hermes parse error like:
Root cause is Bumping to |
|
There is a job running Harness tests… testing Harness 😄 Nevertheless, there is nothing wrong with bumping vitest/expect. Thanks! |
The harness repo’s E2E runs against the playground app on RN 0.82.1 (Metro 0.83.3, iOS |
Updates @react-native-harness/runtime to use @vitest/expect@4.0.16 (which depends on chai ^6.2.x) instead of chai 5.x.
Motivation: Hermes cannot parse BigInt literals (e.g. 0n) present in chai@5.3.3, which breaks on-device harness runs.