fix: sync default status/priority when referenced value is deleted #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting the default value for a task status from the custom statuses, the
defaultTaskStatusproperty would remain at the old value.Since there's then no label associated with this value, the UI under Task Properties -> Status -> Default would show another label (the first one). So this looked as if it was "correct". Setting it explicitly to the intended default wouldn't update this either, since the UI filtered this as "no change".
The first time it was set to another value and then back would fix this.
This patch addresses this by ensuring that when the default status/priority is deleted, the default value is also updated. When the UI notices that it is set to a non-existing value, it is also updated.