Merged
Conversation
phnazari
requested review from
benedict-armstrong and
francescoshox
as code owners
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates citation links across the codebase from arXiv preprints to official published versions, along with some documentation cleanup in the introductory notebook.
Key changes:
- Updated citation URLs for LinOSS, LRU, S5, and S4D models from arXiv links to their published conference/proceedings versions
- Removed excessive emojis and streamlined explanatory text in the introduction notebook
- Removed a redundant markdown cell about training speed optimization
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/linax/sequence_mixers/s5.py | Updated S5 reference from arXiv to OpenReview |
| src/linax/sequence_mixers/s4d.py | Updated S4D reference from arXiv to NeurIPS proceedings |
| src/linax/sequence_mixers/lru.py | Updated LRU reference from arXiv to PMLR proceedings |
| src/linax/sequence_mixers/linoss.py | Updated LinOSS reference from arXiv to OpenReview |
| src/linax/models/s5.py | Updated S5 docstring reference to OpenReview |
| src/linax/models/lru.py | Updated LRU docstring reference to PMLR proceedings |
| src/linax/models/linoss.py | Updated LinOSS docstring reference to OpenReview |
| docs/examples/01_introduction_&_classification.ipynb | Removed emojis from section headers and streamlined documentation text |
| README.md | Updated all model paper links in the table to published versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Changes Made