Skip to content

Refactoring codebase#65

Closed
phnazari wants to merge 9 commits intomainfrom
ben/refactor
Closed

Refactoring codebase#65
phnazari wants to merge 9 commits intomainfrom
ben/refactor

Conversation

@phnazari
Copy link
Collaborator

Description

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 📚 Documentation
  • Other

Changes Made

Completely refactored the codebase. We still need to:

  1. update the pypi after renaming the project
  2. add DeltaNet

Copilot AI review requested due to automatic review settings February 18, 2026 09:28
@gemini-code-assist
Copy link

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR represents a complete refactoring of the codebase, renaming the project from "linax" to "discretax" and transitioning from a configuration-based architecture to direct instantiation of components.

Changes:

  • Removed config-based model building in favor of direct class instantiation
  • Renamed project from "linax" to "discretax" throughout codebase and documentation
  • Introduced new utility modules for parameter counting and configuration management

Reviewed changes

Copilot reviewed 90 out of 94 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_smoke.py Removed placeholder smoke test
tests/test_channel_mixers.py Updated to use direct instantiation instead of config-based building
tests/test_blocks_and_models.py Refactored tests to use Sequential composition instead of config-based models
src/linax/utils.py Updated module docstring to reference "discretax"
src/linax/sequence_mixers/*.py Removed config classes, moved parameters to init methods
src/linax/models/*.py Removed model config files, replaced with direct model classes
src/linax/heads/*.py Removed config classes, simplified to direct instantiation
src/linax/encoder/*.py Removed config classes, simplified to direct instantiation
src/linax/channel_mixers/*.py Removed config classes, moved parameters to init methods
src/linax/blocks/*.py Removed config classes, added Resolvable pattern for mixers
src/discretax/utils/*.py Added new utility modules for parameter counting and config management
src/discretax//.py New discretax package structure with refactored components
pyproject.toml Updated project name, metadata, and author order
docs/*.md Updated all documentation to reference "discretax" instead of "linax"
Comments suppressed due to low confidence (3)

tests/test_blocks_and_models.py:1

  • The parameter batch_size is documented but unused in the function body. The docstring states it's 'kept for API consistency' but should clarify why this parameter exists if it serves no functional purpose, or consider removing it if truly unnecessary.
    pyproject.toml:1
  • The author order has been changed in this PR. Ensure this change is intentional and aligns with project contribution agreements or authorship policies.
    mkdocs.yml:1
  • Changed from strict: true to strict: false. This reduces the strictness of documentation builds and may allow errors to go unnoticed. Consider documenting why this change was necessary or reverting if it was unintentional.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

url = {https://github.com/camail-official/linax},
@software{discretax2025,
title = {Discretax: A Lightweight Collection of State Space Models in JAX},
author = {Nazari, Philipp* and Ruscio, Francesco Maria* and Armstrong, Benedict and Rusch, T. Konstantin},
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The citation author order has been changed to list Nazari and Ruscio as co-first authors (indicated by asterisks). This is a significant change in attribution and should be verified as intentional.

Suggested change
author = {Nazari, Philipp* and Ruscio, Francesco Maria* and Armstrong, Benedict and Rusch, T. Konstantin},
author = {Nazari, Philipp and Ruscio, Francesco Maria and Armstrong, Benedict and Rusch, T. Konstantin},

Copilot uses AI. Check for mistakes.
@phnazari phnazari closed this Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants