refactor(workforce): Refactor WorkforceCallback and all related callbacks to async interface #3363
Conversation
…acks to async interface
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coolbeevip
changed the title
fengju0213
left a comment
fengju0213
left a comment
There was a problem hiding this comment.
Everything else looks great—my only concern is that we should keep backward compatibility (or
provide sync wrappers) so existing code doesn’t break when upgrading.
ask for some comments cc @Wendong-Fan
There was a problem hiding this comment.
Thanks for the excellent contribution—the async-first design should definitely help with
throughput and allow callbacks to run I/O without blocking. One question: since the long-
standing public Workforce APIs (e.g., add_single_agent_worker, reset, clone) are now
asynchronous, do we plan to retain the former synchronous entry points (even if just as thin
wrappers) to preserve backward compatibility for existing scripts and examples?
| input_message, response_format=QueryResponse | ||
| ) | ||
| elif isinstance(pipeline_template, Workforce): | ||
| pipeline = pipeline_template.clone() # type: ignore[assignment] |
There was a problem hiding this comment.
still calls Workforce.clone() synchronously
Description
Fixes #3352
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!