Skip to content

fix: reset table bboxes on each page in hybrid parser #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: reset table bboxes on each page in hybrid parser #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions camelot/parsers/hybrid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ def _merge_bbox_analysis(self, lattice_bbox, network_bbox):
self.table_bbox_parses[augmented_bbox] = self.network_parser

def _generate_table_bbox(self):
self.table_bbox_parses = {}
# Collect bboxes from both parsers
self.lattice_parser._generate_table_bbox()
_lattice_bboxes = sorted(
Expand Down
Binary file added tests/files/hybrid_multipage.pdf
View file
Open in desktop
Binary file not shown.
7 changes: 7 additions & 0 deletions tests/test_hybrid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,3 +142,10 @@ def test_hybrid_keyerror(testdir):
filename = os.path.join(testdir, "tabula/schools.pdf")
tables = camelot.read_pdf(filename, flavor="hybrid", pages="4-5")
assert len(tables) >= 1


def test_hybrid_multipage(testdir):
"""Hybrid parser should clear table bboxes on each new page."""
filename = os.path.join(testdir, "hybrid_multipage.pdf")
tables = camelot.read_pdf(filename, flavor="hybrid", pages="1-2")
assert len(tables) == 2 # not 3