Resolve overflow issue, apply Bootstrap styling, optimize performance, and clean up code #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @birm, please review this PR and let me know if any corrections are needed. |
birm
approved these changes
Apr 1, 2024
Member
birm
left a comment
birm
left a comment
There was a problem hiding this comment.
Lovely, thank you! This also complements some other PRs on this page well.
Contributor
Author
|
Great, appreciate it. You can also take a look at this one and let me know what you think @birm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have resolved the overflow issue in cards, applied Bootstrap styling, improved performance by moving scripts, and conducted code cleanup.
snip
before
After
Motivation
The motivation behind this was to address UI overflow problem, enhance styling consistency, optimize page load performance, and improve code maintainability.
Video demo
Recording.5.mp4
Testing
I have tested for responsive behavior and script execution, ensuring no adverse effects on performance.
Questions
None.