Open
Conversation
sryvcr
commented
May 27, 2023
sryvcr
commented
- PEP8 style applied
- Logic fixed
| arrayNumber[numero[x]] = True | ||
|
|
||
| numero = list(numero) | ||
| def guess(self, number: str = None) -> Union[bool, str]: |
Owner
There was a problem hiding this comment.
Puedes intentar darle un nombre mas descriptivo a esta función? además te recomiendo que solo tengas un tipo de valor a retornar (string o boolean), así será mas facil testear la función
Comment on lines
+26
to
+28
| result_x = "" | ||
| result__ = "" | ||
| number = list(number) |
Owner
There was a problem hiding this comment.
Puedes intentar dar nombres mas descriptivos a estas variables?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.