Skip to content

fix: ignore non-FEEL properties in the FEEL rule#231

Open
jarekdanielak wants to merge 1 commit intomainfrom
ignore-properties
Open

fix: ignore non-FEEL properties in the FEEL rule#231
jarekdanielak wants to merge 1 commit intomainfrom
ignore-properties

Conversation

@jarekdanielak
Copy link
Copy Markdown
Contributor

Closes #53

Proposed Changes

Ignore non-FEEL properties even if they are formatted like a FEEL expression.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Copilot AI review requested due to automatic review settings March 31, 2026 13:35
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 31, 2026
@jarekdanielak jarekdanielak requested review from a team, Buckwich and barinali and removed request for a team March 31, 2026 13:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Camunda Cloud feel bpmnlint rule to avoid false positives by skipping FEEL linting for properties that are not intended to contain FEEL expressions, even if their string values start with =.

Changes:

  • Extend the FEEL rule with global and type-specific ignored property lists (e.g. name, zeebe:Input#target, zeebe:Header#key/value).
  • Adjust FEEL-property detection to consider the owning element type (node.$type) when deciding whether to lint.
  • Add test cases ensuring FEEL-like strings in non-FEEL properties are treated as valid (ignored) inputs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/camunda-cloud/feel.spec.js Adds regression tests for FEEL-like values on properties that should be ignored by the FEEL rule.
rules/camunda-cloud/feel.js Introduces ignored-property filtering (global + per $type) before running FEEL linting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Review pending

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feel Rule Reports False Positives

2 participants