fix: make webmodeler webapp component optional#2197
Conversation
The webapp component has been removed from Web Modeler. - Remove webapp sections from helm values (no-domain, domain, mkcert, oidc) - Make port-forward conditional on service existence Ref: camunda/camunda-docs#8453
🔀 Skip Workflow ChecklistCheck the boxes below to skip specific workflows for this PR. Global options
Individual workflows
This checklist is automatically managed. Checked items will skip the corresponding workflow. |
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Kubernetes local-dev and OIDC overlay configurations to align with Web Modeler no longer requiring (or always shipping) a separate webapp component, and makes local port-forwarding resilient when the webapp Service is absent.
Changes:
- Removed
webModeler.webappconfiguration blocks from multiple Helm values overlays (resources, mkcert CA trust, and OIDC env). - Updated the Kind
port-forward.shscript to only display/port-forward Web Modeler when thecamunda-web-modeler-webappService exists.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
local/kubernetes/kind-single-region/procedure/port-forward.sh |
Makes Web Modeler port-forwarding conditional on the camunda-web-modeler-webapp Service existing. |
local/kubernetes/kind-single-region/helm-values/values-no-domain.yml |
Removes the webModeler.webapp.resources section from no-domain Kind values. |
local/kubernetes/kind-single-region/helm-values/values-domain.yml |
Removes the webModeler.webapp.resources section from domain Kind values. |
local/kubernetes/kind-single-region/helm-values/values-mkcert.yml |
Removes mkcert CA trust configuration that was specific to the Node.js webapp component. |
generic/kubernetes/single-region/helm-values/values-oidc.yml |
Removes webModeler.webapp OIDC env configuration, keeping OIDC config focused on the remaining components. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The webapp component has been removed from Web Modeler. - Remove webapp sections from helm values (no-domain, domain, mkcert, oidc) - Make port-forward conditional on service existence Ref: camunda/camunda-docs#8453
The webapp component has been removed from Web Modeler. - Remove webapp sections from helm values (no-domain, domain, mkcert, oidc) - Make port-forward conditional on service existence Ref: camunda/camunda-docs#8453
|
@jfriedenstab can you give a second review to this? Thanks! |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@leiicamundi I'm a bit late as the PR is already merged, but I still left a comment. |
The webapp component has been removed from Web Modeler.
Ref: camunda/camunda-docs#8453
This pull request primarily removes the
webappconfiguration for Web Modeler from various Kubernetes Helm values files, streamlining deployment configurations. Additionally, it updates the port-forwarding script to properly display and forward the Web Modeler service if it is present.Configuration cleanup:
webappsection (including environment variables for OIDC and OAuth2) fromgeneric/kubernetes/single-region/helm-values/values-oidc.ymlto simplify authentication configuration.webappresource requests and limits from bothlocal/kubernetes/kind-single-region/helm-values/values-domain.ymlandlocal/kubernetes/kind-single-region/helm-values/values-no-domain.ymlto reduce redundant or unused resource specifications. [1] [2]webappconfiguration for extra volumes, volume mounts, and environment variables related to mkcert fromlocal/kubernetes/kind-single-region/helm-values/values-mkcert.yml, as it is no longer needed.Port-forwarding improvements:
local/kubernetes/kind-single-region/procedure/port-forward.shto display the Web Modeler service and set up port forwarding for it if available, improving local development and testing workflows. [1] [2]