fix(openshift): when es is disabled, fix templating error of label

[leiicamundi]

Which problem does the PR fix?

closes #2779

Fixes Helm chart rendering failure when deploying on OpenShift with Elasticsearch disabled:

Error: INSTALLATION FAILED: template: camunda-platform/templates/zeebe/1/2/3/4/5/6/7/8/z_compatibility_helpers.tpl:87:30: 
at <.Values.elasticsearch.commonLabels>: wrong type for value; expected map[string]interface {}; got interface {}

This occurs with values like:

elasticsearch:
  enabled: false

global:
  compatibility:
    openshift:
      adaptSecurityContext: force

Root cause: The hasKey function was called on .Values.elasticsearch.commonLabels without ensuring it was a proper map. When elasticsearch was disabled without explicitly defining commonLabels: {}, the value became nil causing the template to fail.

What's in this PR?

Updated the compatibility helpers in charts 8.6 and 8.7 to match the already-correct implementation in 8.8/8.9:

1. Combine conditions using and (elasticsearch.enabled AND adaptSecurityContext == "force")
2. First check if commonLabels key exists, create empty dict if not
3. Then safely check for the tuned.openshift.io/elasticsearch label

Before:

{{- if .Values.elasticsearch.enabled -}}
  {{- if eq .Values.global.compatibility.openshift.adaptSecurityContext "force" -}}
      {{- if not (hasKey .Values.elasticsearch.commonLabels "tuned.openshift.io/elasticsearch") -}}
          {{- $_ := set .Values.elasticsearch.commonLabels "tuned.openshift.io/elasticsearch" "" -}}
      {{- end -}}
  {{- end -}}
{{- end -}}

After:

{{- if and (eq .Values.global.compatibility.openshift.adaptSecurityContext "force") .Values.elasticsearch.enabled -}}
    {{- if not (hasKey .Values.elasticsearch "commonLabels") -}}
        {{- $_ := set .Values.elasticsearch "commonLabels" (dict) -}}
    {{- end -}}
    {{- if not (hasKey .Values.elasticsearch.commonLabels "tuned.openshift.io/elasticsearch") -}}
        {{- $_ := set .Values.elasticsearch.commonLabels "tuned.openshift.io/elasticsearch" "" -}}
    {{- end -}}
{{- end -}}

Files changed:

Chart	File
8.6	templates/zeebe/1/2/3/4/5/6/7/8/z_compatibility_helpers.tpl
8.7	templates/zeebe/1/2/3/4/5/6/7/8/z_compatibility_helpers.tpl

Unit tests added:

Chart	File
8.6	test/unit/camunda/compatibility_helpers_test.go
8.7	test/unit/camunda/compatibility_helpers_test.go
8.8	test/unit/common/compatibility_helpers_test.go
8.9	test/unit/common/compatibility_helpers_test.go

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

• In the repo's root dir, run make go.update-golden-only.
• There is no other open pull request for the same update/change.
• Tests for charts are added (if needed).
• In-repo documentation are updated (if needed).

After opening the PR:

• Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
• Did all checks/tests pass in the PR?

[jessesimpson36]

I think the CI failures were unrelated so I'm rebasing so they rerun