Conversation
eamonnmoloney
left a comment
There was a problem hiding this comment.
This looks good. Can the field be more explicit like, enableIRSA or something like that... right now its not clear what is getting disable when the flag is false
Also, will this be ported to 8.6/7 and 9?
Not sure it's worth for 8.6, 8.7 I can have a look
I'll improve the documentation of it |
|
@eamonnmoloney For 8.6 there is no document store feature, so I implemented it to 8.7, 8.8 and 8.9 only. |
eamonnmoloney
left a comment
There was a problem hiding this comment.
These are good changes. Before merging this, make sure to test they work against the QA documentStore test runs
|
QA integration will be tracked by https://github.com/camunda/product-hub/issues/3388 |
Which problem does the PR fix?
Customer wants to use AWS Document Store with IRSA (IAM Roles for Service Accounts), but the Helm chart currently forces credential injection via secrets, which blocks IRSA from working.
Related:
inc-support-29235-camunda-8-7-document-store-awsRoot cause: When
global.documentStore.type.aws.enabledistrue, the chart always injectsAWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYenvironment variables. The AWS SDK credential chain prioritizes these env vars over IRSA, so even empty values prevent IRSA from being used.What's in this PR?
Added a new configuration option
global.documentStore.type.aws.useCredentialsInSecret:true(default): Credentials are injected via secrets (existing behavior, backward compatible)false: No credentials are injected, allowing IRSA to work via the AWS SDK credential chainUsage
To use Document Store with IRSA:
Charts modified
camunda-platform-8.8camunda-platform-8.9Files changed per chart
values.yamlglobal.documentStore.type.aws.useCredentialsInSecretoptiontemplates/orchestration/statefulset.yamluseCredentialsInSecrettemplates/orchestration/importer-deployment.yamltemplates/console/deployment.yamltemplates/connectors/deployment.yamltemplates/identity/deployment.yamltemplates/optimize/deployment.yamltemplates/web-modeler/deployment-webapp.yamltemplates/web-modeler/deployment-restapi.yamltest/unit/common/documentstore_irsa_test.goTemplate condition change
Before:
After:
Backward Compatibility
✅ Fully backward compatible - The default value is
true, which preserves the existing behavior. Users who don't set this option will see no change.Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: