Skip to content

Conversation

jarekdanielak
Copy link
Contributor

Related to camunda/camunda-modeler#4967

Proposed Changes

In a feel: required property, mark value as deprecated if it doesn't start with =.

image

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@jarekdanielak jarekdanielak self-assigned this Aug 29, 2025
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Aug 29, 2025
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this is indicated in Sublime Text:

capture KrT2DN_optimized

I could not verify this doesn't trigger an error, nor could I verify that we can distinguish errors and deprecation in our tooling.

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we start to use deprecated more it probably makes sense to add respective test coverage:

  • What is deprecated
  • How can we source the deprecated information for tooling (problems panel)

@barmac
Copy link
Contributor

barmac commented Sep 10, 2025

Regarding deprecated usage, some discovery was done in #187 (comment)

@nikku
Copy link
Member

nikku commented Sep 10, 2025

I don't think #187 (comment) is conclusive. In this gist I demonstrate how we can have both, deprecation warnings and errors when validating with AJV. Question is if we need it, or if hints in JSON-schema enabled editors is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants