Skip to content

fix: Revert ARGO_KEYFORMAT to match old manifests for kfp-operators#307

Merged
mvlassis merged 2 commits intomainfrom
argo-keyformat-revertg
Jan 21, 2026
Merged

fix: Revert ARGO_KEYFORMAT to match old manifests for kfp-operators#307
mvlassis merged 2 commits intomainfrom
argo-keyformat-revertg

Conversation

@mvlassis
Copy link
Contributor

@mvlassis mvlassis commented Jan 20, 2026

This PR reverts the change to ARGO_KEYFORMAT to use the old value used in Kubeflow 1.10. Context is provided in canonical/kfp-operators#821 (comment).

@github-actions github-actions bot added the Libraries: Out of sync The charm libs used are out-of-sync label Jan 20, 2026
@mvlassis mvlassis changed the title fix: Revert Argo keyformat fix: Revert ARGO_KEYFORMAT to match old manifests for kfp-operators Jan 20, 2026
Copy link
Contributor

@MattiaSarti MattiaSarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: let's leave a comment/link to highlight the fact that ARGO_KEYFORMAT is not applied as upstream and the reason

@mvlassis mvlassis merged commit 4460a3d into main Jan 21, 2026
9 checks passed
@mvlassis mvlassis deleted the argo-keyformat-revertg branch January 21, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants