docs(ec2_image_builder): implementation proposal#133
docs(ec2_image_builder): implementation proposal#133rpocase wants to merge 1 commit intocanonical:mainfrom
Conversation
| - eu-west-1 | ||
| future_region_support: true | ||
|
|
||
| offer: |
There was a problem hiding this comment.
This doesn't need to be under ec2-image-builder field. using the same offer api.
There was a problem hiding this comment.
it still needs a specific key because it isn't nested alongside an existing ami product. the models will reuse the existing offer structure, though
| #### Full schema example | ||
|
|
||
| ```yaml | ||
| ec2_image_builder: |
There was a problem hiding this comment.
im a bit confused about why we need a separate ec2_image_builder field instead of keeping it under product. the only difference seems to be the version field, which we need to support the DeliveryOption for Ec2ImageBuilderComponent.
would it be possible to keep the existing structure and modify only the version field instead?
There was a problem hiding this comment.
you could perhaps inherit and override version, but i prefer to be explicit here over having the redirect. if there were more model validations directly in AmiProduct i would be more worried about it
| refund_policy: | | ||
| Your refund policy. | ||
|
|
||
| version: |
There was a problem hiding this comment.
i would like to suggest changing only this field by adding a delivery_options field and allowing the driver and changeset to handle it accordingly.
another question: do we want to support multiple version requests? if so, we would need to implement that capability in both the driver and the changeset as well.
There was a problem hiding this comment.
i think that IBVersion will handle this appropriately. is there something i am missing?
rpocase
force-pushed
the
20260303-component-builder-specification
branch
from
d515d13 to
76ddc8f
Compare
ec2_image_builder supports marketplace like listings and is fully supported for seller use cases (both paid and free). this adds a proposed implementation architecture that is backwards compatible with AmiProducts but keeps a consistent look and feel
rpocase
force-pushed
the
20260303-component-builder-specification
branch
from
76ddc8f to
5ca22e9
Compare
2 participants
ec2_image_builder supports marketplace like listings and is fully supported for seller use cases (both paid and free). this adds a proposed implementation architecture
that is backwards compatible with AmiProducts but keeps a consistent look and feel