chore: Sphinx version pin, refactor config to set appropriate default (#68)

.github/workflows/conventional-commits.yaml

@@ -0,0 +1,23 @@
+name: test
+on:
+  push:
+    branches:
+      - "main"
+      - "feature/*"
+      - "hotfix/*"
+      - "release/*"
+      - "renovate/*"
+  pull_request:
+
+jobs:
+  commit-message:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: conventional commits
+        uses: webiny/action-conventional-commits@v1.3.0
+        with:
+          allowed-commit-types: "build,chore,ci,docs,feat,fix,perf,refactor,style,test"

.github/workflows/tests.yaml

@@ -17,10 +17,6 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - name: conventional commits
-        uses: webiny/action-conventional-commits@v1.3.0
-        with:
-          allowed-commit-types: "build,chore,ci,docs,feat,fix,perf,refactor,style,test"
       - name: Setup Python
         uses: actions/setup-python@v5
         with:

canonical_sphinx/config.py

@@ -220,14 +220,11 @@
     if (
         config.latex_elements == {}
     ):  # pyright: ignore [reportUnnecessaryComparison] type: # ignore[comparison-overlap]
-
         config.latex_elements = ast.literal_eval(config.latex_config)
 
     html_context = config.html_context
 
     disable_feedback_button = config.disable_feedback_button
-    if html_context.get("github_issues") and not disable_feedback_button:
-        html_js_files.append("github_issue_links.js")
 
     values_and_defaults = [
         ("product_tag", "_static/tag.png"),
@@ -244,6 +241,9 @@
     for value, default in values_and_defaults:
         html_context.setdefault(value, default)
 
+    if html_context.get("github_issues") and not disable_feedback_button:
+        html_js_files.append("github_issue_links.js")
+
     html_context["has_contributor_listing"] = has_contributor_listing
 
     config.html_js_files.extend(html_js_files)

pyproject.toml

@@ -2,7 +2,7 @@
 name = "canonical-sphinx"
 dynamic = ["version", "readme"]
 dependencies = [
-    "Sphinx",
+    "Sphinx>=7.1.2",
     "furo",
     "myst-parser",
     "linkify-it-py",