Conversation
2ff0d70 to
c86887e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2114 +/- ##
=======================================
Coverage 77.20% 77.20%
=======================================
Files 16 16
Lines 1676 1676
=======================================
Hits 1294 1294
Misses 382 382
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
514c6d9 to
71abda2
Compare
a0e2cda to
e45ee1b
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive end-to-end Playwright tests for the Canonical.com navigation system, covering primary navigation, dropdowns, search functionality, secondary navigation, mobile behavior, responsive design, and accessibility features.
Key Changes
- Added 426 lines of navigation test coverage across multiple test suites (structure, interactions, search, mobile, responsive, accessibility)
- Created reusable navigation helper functions and constants for test maintainability
- Enhanced HTML navigation template with accessibility improvements (aria-labels) and test-friendly IDs
- Updated Playwright configuration to support multiple test projects with separate test directories
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/playwright/tests/navigation/navigation-flows.spec.ts | Main test file containing comprehensive E2E test suites for navigation flows, covering primary navigation structure, dropdown interactions, search functionality, secondary navigation, cross-linking, mobile behavior, responsive design, and accessibility |
| tests/playwright/helpers/navigation-helpers.ts | Helper functions and constants for navigation testing including viewport configurations, navigation items, and utility functions for interactions |
| tests/playwright/tests/navigation/README.md | Documentation describing test coverage, helper functions, viewport testing, and maintenance guidelines |
| templates/navigation/navigation.html | Added IDs to search buttons (mobile/desktop) and aria-labels to search form buttons for improved accessibility and testability |
| playwright.config.ts | Updated test directory from forms-specific to general tests directory and added separate projects for forms and navigation test suites |
| package.json | Added test-e2e npm script for running Playwright tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Onibenjo works well! I've just left a few comments |
7796470 to
dbff677
Compare
Add comprehensive end-to-end tests for the navigation system including: - Primary navigation structure and accessibility - Dropdown interactions for all menu items - Search functionality testing - Secondary navigation validation - Responsive behavior across multiple viewports - Accessibility and keyboard navigation - Error handling scenarios Includes test helpers and configuration updates to support the new test suite.
The mobile small viewport was removed as it's no longer needed for testing, while tablet landscape was added to improve test coverage for tablet devices
de8bd04 to
7ed9f73
Compare
|
LGTM! |
Done
Add e2e playwright test flow for navigation
[Driveby]:
QA
yarn test-e2eIssue / Card
Fixes # https://warthogs.atlassian.net/browse/WD-24182
Screenshots
[if relevant, include a screenshot]