Open
Conversation
imanenami
approved these changes
Jan 19, 2026
|
I suggest to update the rust version in charmcraft.yaml to fix the build issue, otherwise the release would fail :) |
marcoppenheimer
approved these changes
Jan 20, 2026
marcoppenheimer
requested changes
Jan 20, 2026
There was a problem hiding this comment.
Actually, I don't think we should do this.
Let's keep the default being production, and ensure that during tests + local deployments, we set the testing profile.
As an FYI, Cassandra uses this formula for allocating JVM heap size:
max(min(1/2 ram, 1024MB), min(1/4 ram, 8GB)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current default is "production" which will use half of all available memory. This is not right specially in the context of LXD, since memory constraints need a specific config to be set.