fix: adjust the dry-run behavior and file parsing#130
Merged
deusebio merged 2 commits intokf-8396-automate-risk-promotionfrom Mar 2, 2026
Merged
Conversation
Member
misohu
commented
Feb 26, 2026
misohu
commented
- Cleaned up charms_promotions.py and removed stale commented code.
- Added explicit --dry-run / --apply flags (dry-run stays default).
- Dry-run now prints real charmcraft release ... commands instead of Python list output.
- Fixed text parsing so full juju status output works (including model/controller section).
- Added warning+skip behavior for charms where charmcraft status fails due to missing permissions, instead of aborting the whole run.
- Added a small usage note in README.md.
deusebio
approved these changes
Mar 2, 2026
Contributor
deusebio
left a comment
deusebio
left a comment
There was a problem hiding this comment.
All changes look good! Also I like to enforce either dry-run or apply. I believe it is more explicit
deusebio
merged commit 17aae46
into
kf-8396-automate-risk-promotion
3 of 6 checks passed
deusebio
pushed a commit
that referenced
this pull request
Mar 2, 2026
deusebio
pushed a commit
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.