Workaround bad CHECKBOX_RUNTIME value in gl_support and reboot tests and fix bad path in gl_support (Bugfix)#2292
Workaround bad CHECKBOX_RUNTIME value in gl_support and reboot tests and fix bad path in gl_support (Bugfix)#2292tomli380576 wants to merge 20 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where $CHECKBOX_RUNTIME environment variable contains multiple space-separated paths, causing problems when used to construct Path objects. The fix explicitly constructs the correct checkbox runtime path instead of relying on the multi-path environment variable.
Changes:
- Updated path construction in gl-support test to use an explicit hardcoded path instead of concatenating
CHECKBOX_RUNTIMEwithGLMARK2_DATA_PATH
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomli380576
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomli380576
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2292 +/- ##
==========================================
+ Coverage 54.49% 54.51% +0.01%
==========================================
Files 409 409
Lines 43970 43988 +18
Branches 8100 8106 +6
==========================================
+ Hits 23961 23979 +18
- Misses 19190 19191 +1
+ Partials 819 818 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tomli380576
changed the title
tomli380576
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tomli380576
changed the title
|
Closing this in favor of: #2314 |
Description
This PR is a workaround for #2295. Explicitly constructing CHECKBOX_RUNTIME sort of avoids this problem for now.
Resolved issues
$CHECKBOX_RUNTIME looks like this:
but we only want
/snap/checkbox/20486/checkbox-runtime, which can be constructed with$SNAP/checkbox-runtime.Also fixed the issue with
CHECKBOX_RUNTIME / GLMARK2_DATA_PATHresolving to just GLMARK2_DATA_PATH. Originally GLMARK2_DATA_PATH had a leading slash which would override CHECKBOX_RUNTIME when using the truediv operator/.Documentation
Tests
Classic frontend gl support test: https://certification.canonical.com/hardware/201812-26713/submission/470611/
Important
That submission was done with
checkbox control <ip>. If we directly run checkbox.checkbox-cli, it will fail because XDG_SESSION_TYPE is not captured.Strict frontend gl support test: https://certification.canonical.com/hardware/201812-26713/submission/470624/
Classic frontend reboot test: https://certification.canonical.com/hardware/201812-26713/submission/470628/