feat(26.04): add ethtool#881
Conversation
|
|
Test CoverageAverage Total Coverage: 66.67% Arch: aarch64Coverage: 66.67%
|
| /etc/network/if-pre-up.d/ethtool: | ||
| /etc/network/if-up.d/ethtool: |
There was a problem hiding this comment.
These are scripts and we should test them.
Also I can see these scripts check for /usr/sbin/ethtool so ethtool_bins should be included in the essential of this slice.
There was a problem hiding this comment.
Testing the behavior of the scripts via ifup/ifdown inside a chroot is usually brittle (needs ifupdown installed/configured, interface state, env vars, etc.), so I would not think it's the best idea, but I can maybe add tests if we really want them tested.
There was a problem hiding this comment.
i'd at the very least run them with some mocked /usr/sbin/ethtool (or even without it, since the scripts seem to test -x $ETHTOOL || exit 0), just to check they run.
see #881 (comment)
There was a problem hiding this comment.
( obviously if you can test them more then please do :) , but yeah, there is a point at which you've testing /usr/sbin/ethtool and not these scripts )
| essential: | ||
| - ethtool_bins |
There was a problem hiding this comment.
| essential: | |
| - ethtool_bins | |
| essential: | |
| - base-files_bin | |
| - dash_bins | |
| - ethtool_bins | |
| - sed_bins |
these require dash to run + the shebang references /bin/sh so they need the symlink from base files + if-up.d/ethtool wants sed
Proposed changes
Add ethtool for Ubuntu Core 26
Checklist