feat(26.04): update ca-certificates(-java)#908
Open
lczyk wants to merge 9 commits intocanonical:ubuntu-26.04from
Open
feat(26.04): update ca-certificates(-java)#908lczyk wants to merge 9 commits intocanonical:ubuntu-26.04from
ca-certificates(-java)#908lczyk wants to merge 9 commits intocanonical:ubuntu-26.04from
Conversation
Test CoverageAverage Total Coverage: 42.99% Arch: aarch64Coverage: 42.99%
|
vpa1977
approved these changes
Feb 18, 2026
vpa1977
left a comment
vpa1977
left a comment
There was a problem hiding this comment.
Looks good, some nits present.
I am not sure about renaming the slice - we are breaking the backwards compatibility here.
| chroot . find /etc/ssl/certs/ -name *.pem -exec echo +{} \; > "$rootfs/certs" | ||
|
|
||
| mkdir -p proc/self | ||
| for java in $(find /usr/lib/jvm -name java -type f); do |
There was a problem hiding this comment.
We can use a newer pattern from opendk-25 https://github.com/canonical/chisel-releases/blob/ed7f68cf72626e709cd38e5580262e7bb1dab19f/tests/spread/integration/openjdk-25-jdk-headless/task.yaml#L15C1-L17C1
java=/$(find "$ROOTFS" -name java -type f -printf '%P\n' -quit 2>/dev/null)
|
|
||
| slices: | ||
| bins: | ||
| jars: |
There was a problem hiding this comment.
General note: not sure if we can remove slice without leaving an alias for the backwards compatibility? @cjdcordeiro
| # https://www.gnu.org/software/coreutils/manual/html_node/Summarizing-files.html | ||
| summarizing-files: | ||
| essential: | ||
| - coreutils-from-gnu_wc-utility |
There was a problem hiding this comment.
nit/no action: This looks like a separate PR for coreutils update, but there are already too many open PRs here =)
|
|
||
| rootfs="$(install-slices ca-certificates_data python3.13_core)" | ||
| cp /etc/resolv.conf "$rootfs/etc/" | ||
| chroot "$rootfs" /usr/bin/python3.13 -c "import urllib.request;urllib.request.urlopen('https://example.com')" No newline at end of file |
| echo -e "line1\nline2\nline3" > "$rootfs_wc/test_file" | ||
| test "$(chroot "$rootfs_wc" gnuwc -l test_file | awk '{print $1}')" = "3" | ||
| test "$(chroot "$rootfs_wc" gnuwc -w test_file | awk '{print $1}')" = "3" | ||
| test "$(chroot "$rootfs_wc" gnuwc -c test_file | awk '{print $1}')" = "18" No newline at end of file |
| echo -e "line1\nline2\nline3" > "$rootfs_wc/test_file" | ||
| test "$(chroot "$rootfs_wc" gnuwc -l test_file | awk '{print $1}')" = "3" | ||
| test "$(chroot "$rootfs_wc" gnuwc -w test_file | awk '{print $1}')" = "3" | ||
| test "$(chroot "$rootfs_wc" gnuwc -c test_file | awk '{print $1}')" = "18" No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
ca-certificatesandca-certificates-javaslices frombinstoscriptsandjarsca-certificates_scriptsRelated issues/PRs
n/a
Forward porting
n/a
Checklist