chore(stages): enable type checking #6672
Merged
+48
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Init()'s initialization code is self-referential and has runtime ordering that prevents static analysis. Create a property Init.ds which only returns an initialized DataSource. This narrows the possible code paths that mypy must check and makes static analysis possible.
holmanb
force-pushed
the
holmanb/mypy-stages
branch
from
71eab44 to
ab13016
Compare
holmanb
changed the title
blackboxsw
approved these changes
Jan 23, 2026
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
LGTM. Just two minor nits:
- type hint on _get_per_boot_network_semaphore ... -> _Semaphore
- in your squashed commit, please note the included 'fix' to limit writing netcfg only when non-empty.
| self._write_network_config_json(netcfg) | ||
|
|
||
| if netcfg: | ||
| self._write_network_config_json(netcfg) |
Collaborator
There was a problem hiding this comment.
This change is unrelated to typing changes, but I agree we don't want to attempt to persist netcfg if it is empty or None, that'd cause a traceback in JSON marshaling within writE_network_config_json.
Member
Author
There was a problem hiding this comment.
This change is unrelated to typing changes
That's not true. Undo this change and mypy spots the error:
cloudinit/stages.py:1092: error: Argument 1 to "_write_network_config_json" of "Init" has incompatible type "dict[Any, Any] | None"; expected "dict[Any, Any]" [arg-type]
Collaborator
There was a problem hiding this comment.
Ahh excellent. Thank you mypy! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init()'s initialization code is self-referential and has runtime
ordering that prevents static analysis.
Create a property Init.ds which only returns an initialized DataSource.
This narrows the possible code paths that mypy must check and makes
static (and human) analysis possible.