refactor: simplify the system interface#153
Merged
tonyandrewmeyer merged 9 commits intocanonical:mainfrom Feb 18, 2026
Merged
Conversation
tonyandrewmeyer
commented
Feb 15, 2026
tonyandrewmeyer
commented
Feb 15, 2026
tonyandrewmeyer
commented
Feb 15, 2026
tonyandrewmeyer
commented
Feb 15, 2026
…ests need ro handle that.
benhoyt
reviewed
Feb 15, 2026
benhoyt
approved these changes
Feb 16, 2026
Collaborator
benhoyt
left a comment
benhoyt
left a comment
There was a problem hiding this comment.
Thanks, this is much nicer. Just one small suggestion on moving the non-interface stuff to a new file, but approving optimistically.
Collaborator
|
Oh, and I also didn't look at the test failures / pending tests. |
Contributor
Author
They're unrelated to this PR. The pending ones are because the repo is misconfigured - I'm sorting that with @james-garner-canonical. The failures are the MicroK8s issue discussed st daily yesterday. |
benhoyt
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR minimises the
systeminterface, replacing duplicative methods with helpers.Run*methods are simplified into a singleRunmethodReadHomeDirFileis replaced with the existingReadFile, andWriteHomeDirFileis replaced with a newWriteFile(for consistency)Helpers are added for: