fix: Use the required Go toolchain on 1.13.2#60
Merged
mateoflorido merged 1 commit intomainfrom Dec 12, 2025
Merged
Conversation
HomayoonAlimohammadi
approved these changes
Dec 11, 2025
Contributor
HomayoonAlimohammadi
left a comment
HomayoonAlimohammadi
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot @mateoflorido
bschimke95
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updates the
1.13.2/rockcraft.yamlconfiguration to improve the build process for thecorednspart, and using the right mechanism for the variables used in the Makefile: https://github.com/coredns/coredns/blob/v1.13.2/Makefileafter: [pebble]to thecorednspart to explicitly declare thatcorednsshould be built afterpebble, ensuring proper build order. Pebble uses 1.23-fips/stable: https://github.com/canonical/rockcraft/blob/37ccd575371823c35e9586735962e496c3927893/rockcraft/pebble.py#L1401.24-fips/stablechannel before buildingcoredns, preventing Pebble from downgrading Go to1.23-fips/stable.