Skip to content

fix: only do LXD compat checks on Ubuntu#762

Merged
sergiusens merged 1 commit intohotfix/2.3from
CRAFT-4565-lxd-provider-launched-environment-fails-on-fedora-39
Jun 20, 2025
Merged

fix: only do LXD compat checks on Ubuntu#762
sergiusens merged 1 commit intohotfix/2.3from
CRAFT-4565-lxd-provider-launched-environment-fails-on-fedora-39

Conversation

@sergiusens
Copy link

@sergiusens sergiusens commented Jun 18, 2025

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint && make test?

Fixes #753

@sergiusens sergiusens force-pushed the CRAFT-4565-lxd-provider-launched-environment-fails-on-fedora-39 branch 3 times, most recently from 2ffa26c to 93d7bc6 Compare June 18, 2025 23:34
@sergiusens
Copy link
Author

@sergiusens sergiusens marked this pull request as ready for review June 19, 2025 11:54
Copy link
Contributor

@upils upils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions/questions but otherwise LGTM!

@sergiusens sergiusens force-pushed the CRAFT-4565-lxd-provider-launched-environment-fails-on-fedora-39 branch from 93d7bc6 to 4aa45f1 Compare June 19, 2025 14:53
Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this a blocking review for the date fix.

@sergiusens sergiusens force-pushed the CRAFT-4565-lxd-provider-launched-environment-fails-on-fedora-39 branch from 885c595 to 2d41d41 Compare June 19, 2025 19:51
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens force-pushed the CRAFT-4565-lxd-provider-launched-environment-fails-on-fedora-39 branch from 2d41d41 to 411f6d5 Compare June 19, 2025 20:00
@sergiusens sergiusens merged commit 789c32e into hotfix/2.3 Jun 20, 2025
22 of 24 checks passed
@sergiusens sergiusens deleted the CRAFT-4565-lxd-provider-launched-environment-fails-on-fedora-39 branch June 20, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants