Conversation
There was a problem hiding this comment.
Suggestions for this PR:
-
Let's add a CI workflow that runs the application's tests. I've pushed some commits to do that. The tests are currently failing, but they should pass after we apply my other suggestions.
-
Fix the application's tests. I ran into a couple of issues, one related to creating the superuser more than once, and one related to asserting changes too quickly. See comments.
-
The new URL field is displaying correctly but the href is broken.
-
Keep the
testuser in initial_data.yaml. I think you may have removed this by accident?
Suggestions for follow-up PRs:
-
When looking at a project page, it would be nice to have a way to go back to the dashboard. Perhaps a "← back to dashboard" link/button next to the log in button?
-
Once I've logged in, it's hard to tell that I'm logged in. Maybe some kind of global indicator and/or link to the admin area would be helpful?
dashboard/projects/templates/projects/partial_project_basics.html
Outdated
Show resolved
Hide resolved
Now loads initial_data.yaml that includes built-in superuser and driver users.
Co-authored-by: Dave Wilding <tech@dpw.me>
…to more-frontend-fixes
|
Tests passing. Merging so that the publishing workflow can start running. |
Pretty sure this contains everything that #55 does.
What it does:
{% if not perms.projects.change_condition %}to{% if not perms.projects.change_projectobjectivecondition %}