Merged
Conversation
Now loads initial_data.yaml that includes built-in superuser and driver users.
Co-authored-by: Dave Wilding <tech@dpw.me>
…to more-frontend-fixes
dwilding
reviewed
Sep 15, 2025
Comment on lines
+135
to
+136
| LOGIN_REDIRECT_URL = "projects:project_list" | ||
| LOGOUT_REDIRECT_URL = "projects:project_list" |
Collaborator
There was a problem hiding this comment.
I just pushed a commit to add these to dashboard_rock_patch/dashboard/settings.py too.
| urlpatterns = [ | ||
| path("admin/doc/", include("django.contrib.admindocs.urls")), | ||
| path("admin/", admin.site.urls), | ||
| path("accounts/", include("django.contrib.auth.urls")), |
Collaborator
There was a problem hiding this comment.
What does this do? I tried opening http://localhost:8000/accounts but I got a page not found error - so I must be misunderstanding something.
Collaborator
There was a problem hiding this comment.
I did some research into this. I understand the purpose now. It's so that we can use user authorisation URLs that don't need to go via the admin interface. This makes sense, now that we support live editing on the project pages.
dwilding
reviewed
Sep 16, 2025
dwilding
reviewed
Sep 16, 2025
dwilding
approved these changes
Sep 16, 2025
Collaborator
dwilding
left a comment
dwilding
left a comment
There was a problem hiding this comment.
Approved with a couple of suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.