Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the CI/CD pipeline by removing the LIBDQLITE_TRACE environment variable from test workflows and optimizing the build configuration for the latest dependencies workflow. The changes rely on emergency printing of the last 8k log entries for debugging and introduce x86-64-v3 instruction set optimization for performance testing.
- Removed
LIBDQLITE_TRACE=1environment variable from test runs in both workflows - Added
CFLAGS="-march=x86-64-v3"to the configure command in latest-deps workflow for optimized builds
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/latest-deps.yml | Removed LIBDQLITE_TRACE export and added x86-64-v3 optimization flags to configure command |
| .github/workflows/build-and-test.yml | Removed LIBDQLITE_TRACE from test environment variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes the CI/CD by:
LIBDQLITE_TRACEas we can now rely on the emergency printing of the last 8k entries which is normally enough to understand the problemx86-64-v3instruction set for "latest deps" so that we can see the difference between a normal build and an optimized one (available sincequesting)