Conversation
letFunny
reviewed
Nov 24, 2025
letFunny
approved these changes
Nov 24, 2025
Collaborator
letFunny
left a comment
letFunny
left a comment
There was a problem hiding this comment.
We had a good offline discussion about this, I see all the benefits with this approach so let's go ahead and merge it. Thanks Marco!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares for the next release. It also changes the script so that versioning does not rely any more on the git tag as this created a problem with the current version of the unstable package (which was still at
1.18.2despite being on top of1.18.3) as the tags are on a different branch (v1.18.x) and are not reachable from the unstable branch.A different option would have been to join
mainwithv1.18.xbut I think it more work.