Skip to content

chore: refactor vm health [DO NOT MERGE WITHOUT CHANGING BASE TO MAIN] #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

yanksyoon
Copy link
Member

@yanksyoon yanksyoon commented Aug 4, 2025

DO NOT MERGE WITHOUT CHANGING BASE TO MAIN

Applicable spec:

Overview

  • Remove VM Health information from VM dataclass
  • Calculate health from RunnerInstance

Rationale

  • VM's health attribute was a mutating property. Remove the mutation.
  • RunnerInstance's health is also a mutating property. Remove the mutation.

Juju Events Changes

Module Changes

Library Changes

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The application version number is updated in github-runner-manager/pyproject.toml.

No user facing changes.

@yanksyoon yanksyoon changed the base branch from main to chore/refactor-cloud-runner-instance August 4, 2025 10:44
Copy link
Member Author

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review help comments

@yanksyoon yanksyoon changed the title chore: refactor vm health chore: refactor vm health [DO NOT MERGE WITHOUT CHANGING BASE TO MAIN] Aug 4, 2025
@yanksyoon yanksyoon changed the base branch from chore/refactor-cloud-runner-instance to main August 8, 2025 03:21
Copy link
Contributor

github-actions bot commented Aug 8, 2025

TICS Quality Gate

❌ Failed

The following errors have occurred during analysis:

❌ [ERROR 5333] Project database 'github-runner-operator' already is connected to a started TICSQServer process that has not registered a stop time. To avoid data corruption, analysis is aborted. Details of the other TICSQServer process: started at 2025-07-09 14:32:08.000 by user ubuntu.

.github/workflows/tics.yaml / TICS / TICS GitHub Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants