Skip to content

chore: refactor openstack instantiation [DO NOT MERGE WITHOUT CHANGING BASE TO MAIN] #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: chore/refactor-vm-health
Choose a base branch
from

Conversation

yanksyoon
Copy link
Member

Applicable spec:

Overview

  • Refactor dataclass to not rely on init method but from_... method.

Rationale

  • Datastructure conversions to rely on from_... method as convention, which frees up init method for factories, that will ease the testing.

Juju Events Changes

Module Changes

Library Changes

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The application version number is updated in github-runner-manager/pyproject.toml.

No user facing changes.

@yanksyoon yanksyoon changed the title chore: refactor openstack instantiation chore: refactor openstack instantiation [DO NOT MERGE WITHOUT CHANGING BASE TO MAIN] Aug 6, 2025
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Test results for commit e018935

Test coverage for e018935

Wrote XML report to coverage/coverage.xml

Static code analysis report

Run started:2025-08-06 08:33:33.071944

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2026
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 1

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants