Support dns_record instead of the git repo#100
Draft
nrobinaubertin wants to merge 1 commit intomainfrom
Draft
Conversation
nrobinaubertin
requested review from
DeeKay3,
amandahla,
gregory-schiano and
srbouffard
srbouffard
approved these changes
May 29, 2025
Comment on lines
+84
to
+86
| except ops.model.ModelError as e: | ||
| logger.error("ERROR while updating relation data: %s", e) | ||
| raise |
There was a problem hiding this comment.
We should not be in active state if there's no relation and should checked before
There was a problem hiding this comment.
And the service should be put down when there's no relation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should not be merged.
I keep it as draft because it is not intended to be merged but to be kept as a separate branch.
Overview
Removes support for the git repository way of propagating DNS changes in favor of using the
dns-recordrelation interfaceChecklist
urgent,trivial,complex)