Skip to content

chore: update charm definitions to support Juju 4.0#2231

Merged
Ninfa-Jeon merged 5 commits intocanonical:mainfrom
Ninfa-Jeon:update-charmdef-juju4
Mar 3, 2026
Merged

chore: update charm definitions to support Juju 4.0#2231
Ninfa-Jeon merged 5 commits intocanonical:mainfrom
Ninfa-Jeon:update-charmdef-juju4

Conversation

@Ninfa-Jeon
Copy link
Contributor

@Ninfa-Jeon Ninfa-Jeon commented Feb 19, 2026

Done

  • Updated dashboard charm definitions to support Juju 4.0
  • Added juju-wait-for action to use juju status polling instead of juju wait-for command as it has been deprecated in 4.0. Refer this for more info.

QA

  • Existing E2E workflows stay unaffected with changes to charm build step.
  • New workflows for 4.0 no longer fail with the following error:
ERROR cannot deploy "dashboard": not supported Charm cannot be deployed because:
charm requires Juju version < 4.0.0, model has version 4.0.1
  • New workflows only fail at the "Run tests" step

Details

https://warthogs.atlassian.net/browse/WD-33971

@Ninfa-Jeon Ninfa-Jeon self-assigned this Feb 19, 2026
@webteam-app
Copy link

@Ninfa-Jeon Ninfa-Jeon force-pushed the update-charmdef-juju4 branch 5 times, most recently from edaa9fe to 6cd149a Compare February 24, 2026 16:57
@github-actions
Copy link

github-actions bot commented Feb 24, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 97.45% (🎯 95%) 16920 / 17361
🔵 Statements 97.45% (🎯 95%) 16920 / 17361
🔵 Functions 98.28% (🎯 95%) 687 / 699
🔵 Branches 92.02% (🎯 90%) 3345 / 3635
File CoverageNo changed files found.
Generated in workflow #2606 for commit eb1e0d5 by the Vitest Coverage Report Action

@Ninfa-Jeon Ninfa-Jeon force-pushed the update-charmdef-juju4 branch from 6cd149a to 52cd528 Compare February 24, 2026 17:25
@Ninfa-Jeon Ninfa-Jeon force-pushed the update-charmdef-juju4 branch 2 times, most recently from 85181e8 to 6e0f862 Compare February 25, 2026 04:04
@Ninfa-Jeon Ninfa-Jeon force-pushed the update-charmdef-juju4 branch 2 times, most recently from ba9c17b to a793361 Compare February 26, 2026 10:56
Copy link
Member

@andogq andogq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just one minor change!

@Ninfa-Jeon Ninfa-Jeon force-pushed the update-charmdef-juju4 branch from a793361 to eb1e0d5 Compare March 2, 2026 02:19
@Ninfa-Jeon Ninfa-Jeon merged commit 5858e81 into canonical:main Mar 3, 2026
21 of 43 checks passed
@Ninfa-Jeon Ninfa-Jeon deleted the update-charmdef-juju4 branch March 3, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants