Open
Conversation
Author
marcoppenheimer
previously approved these changes
Oct 21, 2025
zmraul
requested changes
Oct 23, 2025
Contributor
zmraul
left a comment
zmraul
left a comment
There was a problem hiding this comment.
Same comments form canonical/kafka-bundle#112 (review) apply here I think
zmraul
previously approved these changes
Feb 2, 2026
Contributor
zmraul
left a comment
zmraul
left a comment
There was a problem hiding this comment.
LGTM! Make sure the changes are sync
imanenami
force-pushed
the
feat/terraform
branch
from
eb90b78 to
2bfa610
Compare
imanenami
dismissed stale reviews from marcoppenheimer and zmraul
via
432da2d
Author
|
All in sync, following changes made:
|
Contributor
|
I think canonical/karapace-k8s-operator#27 is blocking this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main differences with the VM TF bundle are:
ingress_offervariable is added for the UI integration.cos-agentapplications are replaced with direct integration with the COS offers.