chore: fix screenshot workflow WD-33136#1815
chore: fix screenshot workflow WD-33136#1815omarelkashef wants to merge 1 commit intocanonical:mainfrom
Conversation
df546cd to
f22b2ca
Compare
edlerd
left a comment
There was a problem hiding this comment.
Some thoughts on the open PR below.
0fa910a to
9f60765
Compare
edlerd
left a comment
There was a problem hiding this comment.
Thanks for fixing it. Do you have a link to a local run of the screenshot tests on your branch?
Some observations on the helper changes are below.
Yes, it is included in the PR description. |
9f60765 to
d801998
Compare
edlerd
left a comment
There was a problem hiding this comment.
Good progress! Some thoughts and ideas on how to stailize the test suite below.
Thanks!, I missed that. One thing I noticed when checking the screenshot from that run:
|
d801998 to
a8184f8
Compare
edlerd
left a comment
There was a problem hiding this comment.
Good progress. It is passing now here and producing right screenshots. 👍
A few nitpicks on the code structure below. Then this should be good to merge from my side.
6de441f to
011ed4c
Compare
Signed-off-by: Omar Elkashef <omarelkashef01@gmail.com>
011ed4c to
83fe1d3
Compare
edlerd
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing the screenshots suite :)
Done
QA
Link to successful job run: https://github.com/omarelkashef/lxd-ui/actions/runs/22487790754/job/65141669207